[WIP] Added timeout_after
context manager
#8297
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is just a proof of concept. See #8295 for another option of implementing. I like this one better, but both attempt to solve the same issue.
Added contextmanager to make timeouts on sympy calls available.
Example:
Also added a
timeout
kwarg toExpr.expand
andexpand
as an exampleof how the manager can be used to apply to functions.
caveats
_ask
as a good function to check, because it's called a lot. However, this may (probably will) add considerable overhead to sympy. The best option would be to find a set of functions that are called often enough, but not too often.evaluate
, etc...) also use globals for the same effect, so sympy already isn't threadsafe.timeout
argument tofu
#8295 does, but is incredibly easier to use.