Bugfix/issue429 fuzzy #433
Conversation
…on concept In case of downloading transactions, skip if not found, since it has just been deleted.
| @@ -236,6 +236,16 @@ private boolean checkPreconditions() throws Exception { | |||
| return false; | |||
| } | |||
|
|
|||
| // Check if other operations are running | |||
There was a problem hiding this comment.
Can you elaborate on why you moved this? It makes sense to check for other operations before LsRemote, but I wonder what made you move it.
|
Looks good! |
|
I'll add references to this PR where I think it's appropriate. e.g. the SQL queries where really quite wrong in the first place, it was just coincidence it hadn't broken before. (I actually have a strong suspicion now this is the actual cause of #429) Adding a reference to this pull request doesn't really add anything except: "This is how we stumbled upon it." It is in no way the reason for the change. |
My fuzzy test has been running for a good 20 minutes without yielding any more errors, so I'm going to suggest this branch is finished.
It could be this contains the fix for #429, if that one is caused indirectly by one of these.
@binwiederhier I think these fixes are "obvious" in some sense, but since they concern some critical parts, I want to ask you to look them over.