Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

users/faq: Add nuance to nested folder statement (fixes #428) #439

Merged
merged 1 commit into from Feb 28, 2019

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Feb 28, 2019

My intention was to keep it not recommended, but make it clear that it can be done and mention the one know catastrophic case (circular includes) - I don't think explaining any further is useful, if the user doesn't understand what circular includes are, they just shouldn't do nested folders (or do research aka read the forum).

@AudriusButkevicius
Copy link
Member

It doesn't explain what that circular thing is. There are other caveats seeing your own changes as conflicts etc.

@thomas-zmo08179
Copy link

@imsodin , if you say "it can be done successfully when you know what you're doing", what would you recommend?
DeviceA <-----> DeviceB <------> DeviceC

@imsodin
Copy link
Member Author

imsodin commented Feb 28, 2019

It doesn't explain what that circular thing is.

First comment:

I don't think explaining any further is useful, if the user doesn't understand what circular includes are, they just shouldn't do nested folders (or do research aka read the forum).

Do you disagree with that?

There are other caveats seeing your own changes as conflicts etc.

PR:

This is just one example, there may be other undesired effects.

I won't try and list all possible caveats -> should I not mention circular includes at all?

@imsodin , if you say "it can be done successfully when you know what you're doing", what would you recommend?

If you read the rest, I don't really want to do recommendations. Most certainly not on the github issue tracker, the forum would be the appropriate place for that.

@calmh
Copy link
Member

calmh commented Feb 28, 2019

Honestly this is almost more scary than what was already there :D

@calmh calmh merged commit ebc2cc9 into syncthing:master Feb 28, 2019
@imsodin imsodin deleted the faq-nested branch February 28, 2019 20:23
@AudriusButkevicius
Copy link
Member

I think before it was just don't do it, now it's don't do it because it's beyond what you peasant can understand.

@syncthing syncthing locked and limited conversation to collaborators Feb 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants