Querying ignores is racy leading to potential nil deref #4300
Labels
frozen-due-to-age
Issues closed and untouched for a long time, together with being locked for discussion
Comments
imsodin
added a commit
to imsodin/syncthing
that referenced
this issue
Aug 11, 2017
In addition this function returned an error when .stignore file was not present, which is perfectly valid. Also removed inconsistent nil check in ignores.go (only relevant for tests) and adjusted walk.go to do what it says in comments (check if Matcher is nil) to prevent nil deref in tests. Originally reported in: https://forum.syncthing.net/t/reason-for-panic-maybe-too-little-ram/10346 Regression from syncthing#3996
viable-hartman
pushed a commit
to viable-hartman/syncthing
that referenced
this issue
Aug 25, 2017
In addition this function returned an error when .stignore file was not present, which is perfectly valid. Also removed inconsistent nil check in ignores.go (only relevant for tests) and adjusted walk.go to do what it says in comments (check if Matcher is nil) to prevent nil deref in tests. Originally reported in: https://forum.syncthing.net/t/reason-for-panic-maybe-too-little-ram/10346 Regression from syncthing#3996 GitHub-Pull-Request: syncthing#4301
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
https://forum.syncthing.net/t/reason-for-panic-maybe-too-little-ram/10346
The lock is not held between getting the value for the queried folder from
folderCfgsand fromfolderIgnores. Therefore the latter does not necessarily exist and it's existence isn't checked.PR incoming.
The text was updated successfully, but these errors were encountered: