Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert Local Changes red button does not work correctly #6436

Closed
xarx00 opened this issue Mar 20, 2020 · 4 comments
Closed

Revert Local Changes red button does not work correctly #6436

xarx00 opened this issue Mar 20, 2020 · 4 comments
Assignees
@imsodin
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.5.0

Comments

@xarx00
Copy link
Contributor

xarx00 commented Mar 20, 2020

  • what happened,
    When a Syncthing folder contains locally-changed-items, the red "Revert Local Changes" button is shown. When this button is pressed, it seemingly does nothing. When it is pressed for the second time, the local changes are reverted.

Screenshot: https://ibb.co/Nx3VkqY

  • what you expected to happen instead
    The red button should work on the first press.

In fact, it might be just a GUI refreshing problem. The first press may actually work, but the second press of the button might be needed to refresh the GUI. However, it may be a different problem, because when I reloaded the GUI at the beginning and then pressed the red button (once), it worked correctly.

Version Information

Syncthing Version: v1.4.0
OS Version: Synology NAS DS416play (Linux x64)
Browser Version: Firefox 68.6.0esr
@AudriusButkevicius
Copy link
Member

This is not a very useful bug report, as there is no steps to reproduce the issue, just a collection of observations and expectations.

@xarx00
Copy link
Contributor Author

xarx00 commented Mar 20, 2020 •
edited

I just have a bunch of folders in the state Local Additions. I guess that one can make a folder into this state by e.g. inserting a file into it, but I haven't tried to simulate that.

Maybe an important remark was omitted - the folder should be of the Receive-only type, otherwise the local changes will be immediately propagated to its corresponding device.

This problem was discussed at the end of this thread:
https://forum.syncthing.net/t/how-to-accept-local-changes/14657/65

@AudriusButkevicius
Copy link
Member

Can you try to reproduce that in isolation in a new folder and post the steps to reproduce?

@imsodin
Copy link
Member

imsodin commented Mar 20, 2020

They opened the issue at my request and i believe the screenshots shows pretty clearly what the initial state is, the two steps taken and what's wrong: essentially the states show that things really get reverted, however the local changed items and button stay.

imsodin added a commit to imsodin/syncthing that referenced this issue Mar 24, 2020
@imsodin
lib/model: Unset local flag on deleted files (fixes syncthing#6436)
f6f18f8
@imsodin imsodin self-assigned this Mar 24, 2020
@imsodin imsodin added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Mar 24, 2020
@calmh calmh closed this as completed in ddfa82e Mar 24, 2020
@calmh calmh added this to the v1.5.0 milestone Mar 24, 2020
calmh added a commit to calmh/syncthing that referenced this issue Mar 30, 2020
@calmh
Merge branch 'master' into indirectversions
88a5b34 
* master: (63 commits)
  go.mod: Update jackpal/gateway dependency (fixes syncthing#5288) (syncthing#6469)
  lib/protocol: faster Luhn algorithm and better testing (syncthing#6475)
  lib/protocol: Remove unused channel Connection.preventSends (syncthing#6473)
  lib/weakhash: Fix speed reporting in benchmark (syncthing#6470)
  build: Simplify/correct Windows version tagging (fixes syncthing#6471) (syncthing#6472)
  lib/ur: Use sysctl syscall to get RAM size on Mac (syncthing#6468)
  lib/model: Do Revert/Override synchronously (syncthing#6460)
  lib/syncthing: Save version to db after upgrade ops are done (ref syncthing#6457) (syncthing#6458)
  cmd/ursrv: Minor heatmap tweaks
  lib/model: Remove unused func (syncthing#6456)
  cmd/ursrv: Use OpenStreetMap and Leaflet for heat map (ref syncthing#6150) (syncthing#6454)
  cmd/ursrv: Provide cached locations.json
  authors: Fixup keevBush
  gui, man, authors: Update docs, translations, and contributors
  go.mod: Update quic-go to 0.14.4 (syncthing#6453)
  all: Pass db intervals as args not env vars (syncthing#6448)
  lib/api: Set ServerName on LDAPS connections (fixes syncthing#6450) (syncthing#6451)
  lib/model: Unset local flag on deleted files (fixes syncthing#6436) (syncthing#6449)
  gui: Improve unused device status (fixes syncthing#6416) (syncthing#6445)
  gui, lib/model: Fix for folder stats with r-o and ignoreDel (fixes syncthing#6430) (syncthing#6431)
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Mar 25, 2021
@syncthing syncthing locked and limited conversation to collaborators Mar 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@imsodin imsodin

Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.5.0
Development

No branches or pull requests
5 participants
@calmh @AudriusButkevicius @xarx00 @imsodin @st-review