Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

panic: runtime error: index out of range in processNeeded() #6654

Closed
syncthing-sentry bot opened this issue May 16, 2020 · 0 comments
Closed

panic: runtime error: index out of range in processNeeded() #6654

syncthing-sentry bot opened this issue May 16, 2020 · 0 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.7.0

Comments

@syncthing-sentry
Copy link 

23:01:02 INFO: syncthing v1.6.0-rc.3 "Fermium Flea" (go1.14.3 windows-amd64) teamcity@build.syncthing.net 2020-05-16 12:40:20 UTC
Panic at 2020-05-16T23:01:08+03:00
panic: runtime error: index out of range [116] with length 116

goroutine 116 [running]:
github.com/syncthing/syncthing/lib/model.(*sendReceiveFolder).processNeeded(0xc000500700, 0xc00000f640, 0xc00b54ec60, 0xc00b54eba0, 0xc00b54eae0, 0xc00b54ec60, 0xc00b54eae0, 0x122cbe0, 0xc00af51620, 0xc000447520, ...)
	C:/BuildAgent/work/174e136266f8a219/lib/model/folder_sendrecv.go:466 +0xea1
github.com/syncthing/syncthing/lib/model.(*sendReceiveFolder).pullerIteration(0xc000500700, 0xc00b54eae0, 0x0)
	C:/BuildAgent/work/174e136266f8a219/lib/model/folder_sendrecv.go:266 +0x61e
github.com/syncthing/syncthing/lib/model.(*sendReceiveFolder).pull(0xc000500700, 0x102775800)
	C:/BuildAgent/work/174e136266f8a219/lib/model/folder_sendrecv.go:185 +0x4f6
github.com/syncthing/syncthing/lib/model.(*folder).pull(0xc000500700, 0xc000447c00)
	C:/BuildAgent/work/174e136266f8a219/lib/model/folder.go:315 +0x2af
github.com/syncthing/syncthing/lib/model.(*folder).serve(0xc000500700, 0x122f2a0, 0xc0000d1000)
	C:/BuildAgent/work/174e136266f8a219/lib/model/folder.go:156 +0x8cf
github.com/syncthing/syncthing/lib/util.AsService.func1(0x122f2a0, 0xc0000d1000, 0xc00048bce0, 0x0)
	C:/BuildAgent/work/174e136266f8a219/lib/util/utils.go:183 +0x40
github.com/syncthing/syncthing/lib/util.(*service).Serve(0xc00027a840)
	C:/BuildAgent/work/174e136266f8a219/lib/util/utils.go:247 +0x12f
github.com/thejerf/suture.(*Supervisor).runService.func1(0xc0004b9ef0, 0xc000000002, 0x1e09068, 0xc000500700)
	C:/BuildAgent/work/pkg/mod/github.com/thejerf/suture@v3.0.2+incompatible/supervisor.go:600 +0x7b
created by github.com/thejerf/suture.(*Supervisor).runService
	C:/BuildAgent/work/pkg/mod/github.com/thejerf/suture@v3.0.2+incompatible/supervisor.go:588 +0x62

(https://sentry.syncthing.net/syncthing/syncthing/issues/2038/)

//@calmh
@calmh calmh changed the title panic: runtime error: index out of range [116] with length 116 panic: runtime error: index out of range in processNeeded() May 16, 2020
calmh added a commit to calmh/syncthing that referenced this issue May 16, 2020
@calmh
lib/model: Don't crash when taking rename shortcut (fixes syncthing#6654
a68e625 
)

If we fail to take the rename shortcut we may crash on a later loop,
because we do trickiness with the indexes but the original buckets[key]
in "range buckets[key]" isn't re-evaluated so i exceeds the max index.
calmh added a commit to calmh/syncthing that referenced this issue May 16, 2020
@calmh
lib/model: Don't crash when taking rename shortcut (fixes syncthing#6654
d922257 
)

If we fail to take the rename shortcut we may crash on a later loop,
because we do trickiness with the indexes but the original buckets[key]
in "range buckets[key]" isn't re-evaluated so i exceeds the max index.
calmh added a commit to calmh/syncthing that referenced this issue May 18, 2020
@calmh
Merge branch 'master' into badgermerge
8402f4b 
* master: (167 commits)
  lib/db: Don't panic on seq. coruption when debugging (syncthing#6662)
  cmd/stindex: Add missing KeyType values in stindex dump code (syncthing#6659)
  lib/model: Don't crash when taking rename shortcut (fixes syncthing#6654) (syncthing#6657)
  cmd/syncthing: Don't crash when failing to create default config (fixes syncthing#6655) (syncthing#6658)
  lib/model: Partial revert of rename fix (fixes syncthing#6653) (syncthing#6656)
  lib/model: Partial revert of rename fix (fixes syncthing#6653) (syncthing#6656)
  lib/model: Fix rename handling (ref syncthing#6650) (syncthing#6652)
  lib/db: Filter repeat files in one update (ref syncthing#6650) (syncthing#6651)
  lib/model: Fix rename handling (ref syncthing#6650) (syncthing#6652)
  lib/db: Filter repeat files in one update (ref syncthing#6650) (syncthing#6651)
  docker: Add tzdata for local time log entries
  docker: Improved health check for host networks (syncthing#6649)
  lib/fs: Set execute bits on junctions converted to dirs (ref syncthing#6606) (syncthing#6645)
  lib/model: Close conns when devices are removed (fixes syncthing#6564) (syncthing#6641)
  lib/model: Adjust remote-rename-test to timer-based versions (fixes syncthing#6625) (syncthing#6644)
  lib/fs: Prevent race-detector triggering in tests (fixes syncthing#6608) (syncthing#6642)
  lib/fs: Treat Windows junctions as normal directories (syncthing#6606)
  lib/db: Dont add symlinks to blocks map (fixes syncthing#6637) (syncthing#6639)
  lib/db: Dont add symlinks to blocks map (fixes syncthing#6637) (syncthing#6639)
  Add indirection for large version vectors. (syncthing#6376)
  ...
@calmh calmh added this to the v1.7.0 milestone May 20, 2020
@calmh calmh added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label May 20, 2020
@imsodin imsodin mentioned this issue Jun 29, 2020
Closed
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label May 18, 2021
@syncthing syncthing locked and limited conversation to collaborators May 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.7.0
Development

No branches or pull requests
2 participants
@calmh @st-review