lib/model: Don't crash when taking rename shortcut (fixes #6654) #6657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AudriusButkevicius
approved these changes
May 17, 2020
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
May 18, 2020
* master: (167 commits) lib/db: Don't panic on seq. coruption when debugging (syncthing#6662) cmd/stindex: Add missing KeyType values in stindex dump code (syncthing#6659) lib/model: Don't crash when taking rename shortcut (fixes syncthing#6654) (syncthing#6657) cmd/syncthing: Don't crash when failing to create default config (fixes syncthing#6655) (syncthing#6658) lib/model: Partial revert of rename fix (fixes syncthing#6653) (syncthing#6656) lib/model: Partial revert of rename fix (fixes syncthing#6653) (syncthing#6656) lib/model: Fix rename handling (ref syncthing#6650) (syncthing#6652) lib/db: Filter repeat files in one update (ref syncthing#6650) (syncthing#6651) lib/model: Fix rename handling (ref syncthing#6650) (syncthing#6652) lib/db: Filter repeat files in one update (ref syncthing#6650) (syncthing#6651) docker: Add tzdata for local time log entries docker: Improved health check for host networks (syncthing#6649) lib/fs: Set execute bits on junctions converted to dirs (ref syncthing#6606) (syncthing#6645) lib/model: Close conns when devices are removed (fixes syncthing#6564) (syncthing#6641) lib/model: Adjust remote-rename-test to timer-based versions (fixes syncthing#6625) (syncthing#6644) lib/fs: Prevent race-detector triggering in tests (fixes syncthing#6608) (syncthing#6642) lib/fs: Treat Windows junctions as normal directories (syncthing#6606) lib/db: Dont add symlinks to blocks map (fixes syncthing#6637) (syncthing#6639) lib/db: Dont add symlinks to blocks map (fixes syncthing#6637) (syncthing#6639) Add indirection for large version vectors. (syncthing#6376) ...
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we fail to take the rename shortcut we may crash on a later loop,
because we do trickiness with the indexes but the original buckets[key]
in "range buckets[key]" isn't re-evaluated so i exceeds the max index.