Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't warn encountering an invalid path separator for deleted items #6795

Closed
imsodin opened this issue Jun 25, 2020 · 0 comments
Closed

Don't warn encountering an invalid path separator for deleted items #6795

imsodin opened this issue Jun 25, 2020 · 0 comments
Assignees
@imsodin
Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.8.0

Comments

@imsodin
Copy link
Member

imsodin commented Jun 25, 2020

https://forum.syncthing.net/t/dropping-index-entry-contains-invalid-path-separator-2/15245

We warn when encountering an invalid path separator on windows. Makes sense for files we actually might need, is unnecessary for deleted items though.
@imsodin imsodin added the enhancement New features or improvements of some kind, as opposed to a problem (bug) label Jun 25, 2020
@imsodin imsodin self-assigned this Jun 25, 2020
imsodin added a commit to imsodin/syncthing that referenced this issue Jun 25, 2020
@imsodin
lib/protocol: Don't warn when dropping deleted invalid item (fixes sy…
018db7b 
…ncthing#6795)
@imsodin imsodin mentioned this issue Jun 25, 2020
Merged
calmh added a commit to imsodin/syncthing that referenced this issue Jul 1, 2020
@calmh
Merge branch 'main' into lib/tHEcASeSPreCIoUs
ecccec7 
* main:
  build: Consistently use 8 hash digits in git describe
  lib/api, lib/model: Fixes around event request tracking (syncthing#6774)
  lib/protocol: Don't warn when dropping deleted invalid item (fixes syncthing#6795) (syncthing#6796)
  lib/model: Don't force rescan already changed items (syncthing#6798)
  lib/scanner: Test weak hash consistency (ref syncthing#5556) (syncthing#6794)
  gui, man, authors: Update docs, translations, and contributors
  lib/ur: Zero our the value before unmarshal (syncthing#6790)
  cmd/ursrv: Skip the duplicate complaints with new index name
  lib/ur: Normalise contract between syncthing and ursrv (syncthing#6770)
  lib/versioner: Create versioning directory recursively (fixes syncthing#6565) (syncthing#6678)
  build(deps): bump github.com/go-ldap/ldap/v3 from 3.1.10 to 3.2.0 (syncthing#6783)
  build(deps): bump golang.org/x/text from 0.3.2 to 0.3.3 (syncthing#6782)
  lib/model: Remove double error handling in performFinish (syncthing#6780)
  lib/db: Correct need accounting on reset (fixes syncthing#6784) (syncthing#6785)
  lib/model: More connection closing (syncthing#6778)
  lib/connections: Correctly fixup port in IPv6 listen URLs (syncthing#6786)
@calmh calmh added this to the v1.8.0 milestone Jul 1, 2020
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 26, 2021
@syncthing syncthing locked and limited conversation to collaborators Jun 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@imsodin imsodin

Labels
enhancement New features or improvements of some kind, as opposed to a problem (bug) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.8.0
Development

No branches or pull requests
3 participants
@calmh @imsodin @st-review