Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAT service fails to terminate during Shutdown #6908

Closed
pop9119 opened this issue Aug 19, 2020 · 3 comments
Closed

NAT service fails to terminate during Shutdown #6908

pop9119 opened this issue Aug 19, 2020 · 3 comments
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone

Comments

@pop9119
Copy link

pop9119 commented Aug 19, 2020

Since version 1.8.0, when-ever a device is told to shutdown syncthing, the process hangs for a bit and the log file prints out:

INFO: connections.Service: Service nat.Service@0xc000184600 failed to terminate in a timely manner.

Based on the logfiles, this takes about 9 secs to timeout. Aside from this slowing down the shutdown process, I am concerned with that service even running since I have NAT transversal disabled on all my syncthing devices. Perhaps this is likely a leftover bug from the 1.7 branch where the process was running even if not configured to.

I have this issue confirmed in Win7,10 & Linux, all running 1.8.0.

@pop9119 pop9119 added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Aug 19, 2020
@AudriusButkevicius
Copy link
Member

The service runs regardless if it's enabled or not, the enablement decides if the service does something or not.

I can't really see on the surface what would cause this.
Is this reliably reproducible for you?

@pop9119
Copy link
Author

pop9119 commented Aug 19, 2020

Yes it is reliably reproducible in that this happens 100% of time even if freshly installed system. I just checked and I don't get the error if I have NAT transveral enabled. (In that a shutdown of syncthing happens with no failure to terminate the nat.Service)

So the error only happens if NAT transveral is not enabled.

@imsodin
Copy link
Member

imsodin commented Aug 19, 2020

I can reproduce, looking into it.

@imsodin imsodin removed the needs-triage New issues needed to be validated label Aug 19, 2020
imsodin added a commit to imsodin/syncthing that referenced this issue Aug 19, 2020
@calmh calmh added this to the v1.9.0 milestone Aug 20, 2020
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Aug 20, 2021
@syncthing syncthing locked and limited conversation to collaborators Aug 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

No branches or pull requests

5 participants