Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not retrying to sync when a new connection is established #8012

Closed
imsodin opened this issue Oct 20, 2021 · 0 comments
Closed

Not retrying to sync when a new connection is established #8012

imsodin opened this issue Oct 20, 2021 · 0 comments
Assignees
@imsodin
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Milestone
v1.18.4

Comments

@imsodin
Copy link
Member

imsodin commented Oct 20, 2021

When a new connection is established, Syncthing should immediately try to sync in case that device has data we are missing and is otherwise unavailable. I think this was the case at some point, but now it isn't. Came up in https://forum.syncthing.net/t/problem-with-start-syncing-after-sender-restart/17488
@imsodin imsodin added the bug A problem with current functionality, as opposed to missing functionality (enhancement) label Oct 20, 2021
@imsodin imsodin self-assigned this Oct 20, 2021
imsodin added a commit to imsodin/syncthing that referenced this issue Oct 20, 2021
@imsodin
lib/model: Pull when a new connection is established (fixes syncthing…
9d5b83f 
…#8012)
@calmh calmh closed this as completed in 517667c Oct 20, 2021
@calmh calmh added this to the v1.18.4 milestone Oct 27, 2021
SimonPickup added a commit to MobiusSync/syncthing that referenced this issue Nov 4, 2021
@SimonPickup
Merge tag 'v1.18.4-rc.2' into ios_try_syncthing_v1.18.4
2478109 
v1.18.4-rc.2

Bugfixes:

- syncthing#7991: Encryption trailer not updated on shortcut
- syncthing#7994: Index "out of sync with reality" on receive-encrypted folder
- syncthing#8000: stdiscosrv + strelaysrv systemd services not restarting on upgrade
- syncthing#8012: Not retrying to sync when a new connection is established

Enhancements:

- syncthing#4293: make "Reduced by ignore patterns" label act like "editIgnoresButton"
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2021
@calmh
Merge branch 'main' into ioutil
d1a36c2 
* main: (32 commits)
  cmd/syncthing: Implement generate as a subcommand with optional API credential setting (fixes syncthing#8021) (syncthing#8043)
  lib/model: Correct "reverting folder" log entry
  lib/model: Correct handling of fakefs cache
  gui, lib: Fix tracking deleted locally-changed on encrypted (fixes syncthing#7715) (syncthing#7726)
  lib/config: Move the bcrypt password hashing to GUIConfiguration (syncthing#8028)
  lib/syncthing: Clean up / refactor LoadOrGenerateCertificate() utility function. (syncthing#8025)
  lib/api: http.Request.BasicAuth instead of custom code (syncthing#8039)
  Normalize CLI options to always use two dashes. (syncthing#8037)
  gui: Display identicons for discovered device IDs. (syncthing#8022)
  cmd/syncthing/cli: indexDumpSize doesn't need a heap (syncthing#8024)
  lib/model: Optimize jobQueue performance and memory use (syncthing#8023)
  lib/model: Limit the number of default hashers on Android (ref syncthing#2220)
  lib/model: Set mod. time after writing trailer in shortcut (ref syncthing#7992)
  lib/protocol: Simplify codeToError, errorToCode
  lib/protocol: Eliminate nativeModel on Unix
  gui: Add direct link to Ignore Patterns from folder panel (fixes syncthing#4293) (syncthing#7993)
  gui: Translate theme names in settings (syncthing#8006)
  lib/model: Pull when a new connection is established (fixes syncthing#8012) (syncthing#8013)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  ...
calmh added a commit to calmh/syncthing that referenced this issue Nov 22, 2021
@calmh
Merge branch 'main' into conn-test
a9c9fb1 
* main: (32 commits)
  cmd/syncthing: Implement generate as a subcommand with optional API credential setting (fixes syncthing#8021) (syncthing#8043)
  lib/model: Correct "reverting folder" log entry
  lib/model: Correct handling of fakefs cache
  gui, lib: Fix tracking deleted locally-changed on encrypted (fixes syncthing#7715) (syncthing#7726)
  lib/config: Move the bcrypt password hashing to GUIConfiguration (syncthing#8028)
  lib/syncthing: Clean up / refactor LoadOrGenerateCertificate() utility function. (syncthing#8025)
  lib/api: http.Request.BasicAuth instead of custom code (syncthing#8039)
  Normalize CLI options to always use two dashes. (syncthing#8037)
  gui: Display identicons for discovered device IDs. (syncthing#8022)
  cmd/syncthing/cli: indexDumpSize doesn't need a heap (syncthing#8024)
  lib/model: Optimize jobQueue performance and memory use (syncthing#8023)
  lib/model: Limit the number of default hashers on Android (ref syncthing#2220)
  lib/model: Set mod. time after writing trailer in shortcut (ref syncthing#7992)
  lib/protocol: Simplify codeToError, errorToCode
  lib/protocol: Eliminate nativeModel on Unix
  gui: Add direct link to Ignore Patterns from folder panel (fixes syncthing#4293) (syncthing#7993)
  gui: Translate theme names in settings (syncthing#8006)
  lib/model: Pull when a new connection is established (fixes syncthing#8012) (syncthing#8013)
  gui, man, authors: Update docs, translations, and contributors
  gui, man, authors: Update docs, translations, and contributors
  ...
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Mar 10, 2023
@syncthing syncthing locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@imsodin imsodin

Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Milestone
v1.18.4
Development

No branches or pull requests
3 participants
@calmh @imsodin @st-review