Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syncthing keeps performing version cleanup even when using External Versioning #8350

Open
tomasz1986 opened this issue May 18, 2022 · 0 comments · May be fixed by #8994
Open

Syncthing keeps performing version cleanup even when using External Versioning #8350

tomasz1986 opened this issue May 18, 2022 · 0 comments · May be fixed by #8994
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)

Comments

@tomasz1986
Copy link
Contributor

How to reproduce:

  1. Enable db,model debug logging.
  2. Create a new folder, and enable Trash Can versioning for it.
  3. Set the cleanup interval to something very low, e.g. 1.
  4. Save the changes. You can now see the cleanup being performed in real time in the log.
  5. Change the versioning type to External. Save the changes.
  6. The cleanup is still being performed in the same interval as before.

Tested with with current main (388b21d).
@tomasz1986 tomasz1986 added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels May 18, 2022
@calmh calmh removed the needs-triage New issues needed to be validated label Mar 10, 2023
tomasz1986 added a commit to tomasz1986/syncthing that referenced this issue Jul 21, 2023
@tomasz1986
gui, lib/model: Disable periodic cleanup when versions are kept forev…
9e4265b 
…er (fixes syncthing#8350)

Currently, the cleanup is set to run on a periodic timer regardless of
the days to keep versions. Because of this, even if versions are set to
be kept forever, the cleanup still runs on the timer. Furthermore, the
cleanup also runs even when using external versioning in spite of it
doing nothing for that versioning type.

This changes the behaviour as follows.

1. Cleanup is disabled when using external versioning.
2. Cleanup only runs when the days to keep versions are set to a value
   higher than "0".
3. When using Trash Can, Simple or Staggered versioning with the value
   above set to "0", the cleanup being "Disabled" is displayed in the
   folder information in the GUI even if the cleanup value is at its
   default.
4. In addition to the above, the cleanup input field is automatically
   disabled with a warning message informing the user about it being
   disabled when the number of days is set to "0".

Signed-off-by: Tomasz Wilczyński <twilczynski@naver.com>
@tomasz1986 tomasz1986 linked a pull request Jul 21, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement)
Projects
None yet
Milestone
No milestone
2 participants
@calmh @tomasz1986