Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Autofill Breaks Authentication #8376

Closed
Renegade605 opened this issue Jun 7, 2022 · 0 comments · Fixed by #8377
Closed

Chrome Autofill Breaks Authentication #8376

Renegade605 opened this issue Jun 7, 2022 · 0 comments · Fixed by #8377
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Milestone

Comments

@Renegade605
Copy link
Contributor

Renegade605 commented Jun 7, 2022

  • which version of Syncthing and what operating system you are using

v1.20.1, Linux (64-bit Intel/AMD) Build 2022-05-18
Docker container lscr.io/linuxserver/syncthing on Unraid v6.10.2

  • browser and version, if applicable

Chrome Version 102.0.5005.63 (Official Build) (64-bit)

  • what happened

If the username and password for Syncthing is saved in Chrome's built-in password manager, it will autofill the fields in the GUI settings dialog with the current username/password. If you try to change anything on the GUI settings page and save it, this will inexplicably break authentication going forward. On page reload, Syncthing will ask for authentication, but the username and password don't work. Sometimes it will partially load the page, sometimes not. Sometimes it does this with the new username and password, sometimes with the old ones, sometimes with a new username and old password or an old username and new password. Regardless, it will ask for authentication again immediately, even if the connection wasn't explicitly denied.

To solve the problem, I had to edit the config.xml file to remove the user and password, delete all saved logins from Chrome, and then set a new username and password through the GUI.

  • what you expected to happen instead, and

The current username and password should not be autofilled in the GUI settings dialog.

  • any steps to reproduce the problem.

Save the username and password in Chrome, then open the GUI settings dialog, then try to change the username and/or password, then save.

  • additional information

I am accessing Syncthing through Nginx Reverse Proxy Manager, but the issue seems to persist when accessing the GUI directly by ip:port. HTTPS is not enabled, as that is handled by the reverse proxy.

  • proposed solution

Add the autocomplete="off" HTML attribute to the inputs in the GUI settings dialog. Sometimes this doesn't behave as expected with passwords; another option that may workaround this is autocomplete="new-password" for the password field.

@Renegade605 Renegade605 added bug A problem with current functionality, as opposed to missing functionality (enhancement) needs-triage New issues needed to be validated labels Jun 7, 2022
calmh pushed a commit that referenced this issue Jun 7, 2022
…8376) (#8377)

Disable Chrome autofill username/password in GUI settings modal dialog.
@calmh calmh added this to the v1.20.3 milestone Jun 14, 2022
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 7, 2023
@syncthing syncthing locked and limited conversation to collaborators Jun 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug A problem with current functionality, as opposed to missing functionality (enhancement) frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion needs-triage New issues needed to be validated
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants