Relax folder label restrictions #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
added
the
enhancement
|
Ah, tests need fixing. I'll get to that. |
|
@st-jenkins run integration tests please |
|
(Windows integration will never complete; I thought I'd disabled that one.) |
AudriusButkevicius
added a commit
that referenced
this pull request
Sep 25, 2015
Relax folder label restrictions
kozec
added a commit
to kozec/syncthing-gtk
that referenced
this pull request
Oct 21, 2015
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
INB4 separating folder ID from label, we might at least let users choose what they like. This bumps the folder id limit to 256 bytes (that's about two tweets worth, should be enough for everyone, right?) and removes the limits on what characters can be used. Tested to work with copy & paste, and the auto add prompt.