Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos #3366

Closed
wants to merge 1 commit into from
Closed

Fix typos #3366

wants to merge 1 commit into from

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Jun 29, 2016

Purpose

Fixes typos in messages and manpages

Testing

Code still compiles and passes tests.
Fix included in the next Debian version for the package.

@aviau
Copy link
Contributor

aviau commented Jun 29, 2016

Fix included in the next Debian version for the package.

Which I am uploading right now <3

@nbraud AFAIK the manpages are maintained in the docs repository.

Edit: Actually, I have already fixed this exact typo in the docs repository.

@nbraud
Copy link
Contributor Author

nbraud commented Jun 29, 2016

@aviau Actually, you already authored the doc fix, so I removed it.

@aviau
Copy link
Contributor

aviau commented Jun 29, 2016

So now that you have authored a line, my understanding is that you should be in the AUTHORS file. Can you add your name there?

@aviau
Copy link
Contributor

aviau commented Jun 29, 2016

So, my understanding is that I should now say:

@bot_name merge

lib: Fix typos in connections/service.go and model/model.go

But I'll wait for somebody to confirm that.

@aviau
Copy link
Contributor

aviau commented Jun 29, 2016

@st-review lgtm

@st-review
Copy link

@aviau: Noted! Need another LGTM or explicit merge command.

@calmh
Copy link
Member

calmh commented Jun 30, 2016

Actually no, fixing a typo is also not a copyright able work by itself. (Also these are strings that no user will normally see.)

@aviau
Copy link
Contributor

aviau commented Jun 30, 2016

@st-review merge it please

lib: Fix typos in connections/service.go and model/model.go

Skip-check: authors

@st-review
Copy link

👌 Merged as 8e39e28. Thanks, @nbraud!

@st-review st-review closed this Jun 30, 2016
st-review pushed a commit that referenced this pull request Jun 30, 2016
Skip-check: authors

GitHub-Pull-Request: #3366
LGTM: aviau
@nbraud nbraud deleted the typos branch July 1, 2016 23:09
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Jun 30, 2017
@syncthing syncthing locked and limited conversation to collaborators Jun 30, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants