New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/syncthing, lib/db, lib/model, lib/protocol: Implement delta indexes (fixes #438) #3427
Conversation
if deviceID == protocol.LocalDeviceID { | ||
if f.LocalVersion > s.localVersion { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s.localVersion
is never set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm? I set it on the line below your comment. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah you mean initialized perhaps? It's initialized to zero as we allocate the "s" struct above.
@st-review merge |
Nothing to pick on, clear and understandable. 🎉 |
Lets hope it works |
Wow! That's really exciting! Updating now... |
Purpose
This is the delta index implementation. There are a few main parts to it:
Testing
I've ran the integration tests that are suitable, including the various "restart during transfer" tests and it checks out. I'm running it myself on my device since a week or so, and it works as far as I can tell.
Docs
Spec update: syncthing/docs#208. It's a backwards compatible change.