-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/scanner: Correctly scan symlinks (#3445) #3446
Conversation
This seems to work. The Info messages disappeared and the symlinks are still there on the receiving side. By the way, don't you need a keyword like "fixes" in the commit message to close the issue? |
Indeed I do, fixed. :) |
@st-review merge it, xduugu tested it |
@calmh: Build status is |
|
||
// Create a folder with a symlink in it | ||
|
||
os.RemoveAll("_symlinks") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
osutil, because this will be flaky on windows I suspect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
inb4 merge
Thanks for the quick fix @calmh |
Purpose
Scan symlinks. :(
Testing
Unit test.