-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
minor accessibility fixes #3297 #3463
Conversation
* add collapsed labels to various things. * Make the dropdowns act as menus * Provide tab key navigation to the tabs in the advanced settings. * Add semicolon to the style in a couple of places.
Hi, Do you guys prefer rebasing or merging onto master? |
Merging master into the branch as necessary is preferred. It'll get squashed at merge time anyhow. |
@st-jenkins add to whitelist |
<img class="logo hidden-xs" src="assets/img/logo-horizontal.svg" height="32" width="117"/> | ||
<img class="logo hidden visible-xs" src="assets/img/favicon-default.png" height="32"/> | ||
</span> | ||
<p class="navbar-text hidden-xs" ng-class="{'hidden-sm':upgradeInfo && upgradeInfo.newer}">{{thisDeviceName()}}</p> | ||
<h1 class="navbar-text hidden-xs" ng-class="{'hidden-sm':upgradeInfo && upgradeInfo.newer}">{{thisDeviceName()}}</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a huge deal if that isn't a heading, so I'll remove it. I meant to remove it, and forgot before pushing.
Also, the html gains double spaces in some places, which I am not fully happy with. |
@@ -514,9 +514,9 @@ <h4 class="panel-title"> | |||
|
|||
<!-- Remote devices --> | |||
<h3 translate>Remote Devices</h3> | |||
<div class="panel-group" id="devices"> | |||
<div class="panel-group" id="devices"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove this mistaken div closing tag I introduced.
<h3 translate>This Device</h3> | ||
<div class="panel panel-default" ng-repeat="deviceCfg in [thisDevice()]"> | ||
<button class="btn panel-heading" data-toggle="collapse" data-target="#device-this"> | ||
<div class="panel panel-default" ng-repeat="deviceCfg in [thisDevice()]"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double space here
I'm fine to merge once last comments are addressed. |
@st-review merge gui: Improve accessibility (fixes #3297) skip-check: authors |
👌 Merged as a8cd9d0. Thanks, @derekriemer! |
Purpose
This fixes a few accessibility issues, mainly the state of certain controls.
Testing
Testing in mozilla firefox, Google Chrome, and Internet explorer with the NVDA screen reader have been done. I'm not sure if this project has integration tests.
Screenshots
This is a GUI change, but the GUI should not visually have changed.