cmd/syncthing: Send Ping events to the disk events API #3929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Ping event is important, as it means that requests complete within a sensible time. The disk events API didn't have the Ping event, so if there were no disk events, the request would keep taking forever. Unless, of course, there's a reverse proxy which times the request out after a suitably large interval (or something else aborts it), in which case Syncthing isn't very happy.
|
@st-review merge it |
st-review
pushed a commit
that referenced
this pull request
Jan 24, 2017
The Ping event is important, as it means that requests complete within a sensible time. The disk events API didn't have the Ping event, so if there were no disk events, the request would keep taking forever. Unless, of course, there's a reverse proxy which times the request out after a suitably large interval (or something else aborts it), in which case Syncthing isn't very happy. GitHub-Pull-Request: #3929
This was referenced Jan 24, 2017
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ping event is important, as it means that requests complete within
a sensible time. The disk events API didn't have the Ping event, so
if there were no disk events, the request would keep taking forever.
Unless, of course, there's a reverse proxy which times the request out
after a suitably large interval (or something else aborts it), in which
case Syncthing isn't very happy.
Testing
Ran Syncthing, saw that the request to the disk events API completed with a ping event after a while.