-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add full path in failed files modal #4023
Conversation
So this makes sense (except we can remove the now useless tooltip), but what happens with long paths?
|
Yeah I wonder if that isn't the best alternative. Although, it would be nice if it could layout the table a bit better so the right column isn't so wide. CSS trickery probably required. I think static column widths are required to be able to use ellipsis breaking (IIRC) or something like that.
|
@calmh I updated the PR andI swapped out the table-condensed for a new table-dynamic class which solves the problems. |
Can you add yourself to authors/nicks/aliases whatever? Otherwise, this looks good to me. |
Let me sort out the authorness, I want that as a separate commit.
|
Done. @st-jenkins retest this please |
I think the table should still be |
@st-review lgtm |
@calmh: Noted! Need another LGTM or explicit merge command. |
@st-review lgtm |
@AudriusButkevicius: Merge failed:
|
@st-review merge gui: Show full failed item path |
Purpose
Display the full file path in the failed files modal such that a user may copy the path in order to investigate.
Testing
Tested on Chrome and Firefox on Windows and Ubuntu.
Screenshots