lib/connections: Only announce punchable nats (fixes #4519) #4523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
reviewed
Nov 17, 2017
lib/connections/kcp_listen.go
Outdated
| } | ||
|
|
||
| // We failed to contact all provided stun servers, chillout for a while. | ||
| // We failed to contact all provided stun servers or the nat is not punchable. | ||
| // Chillout for a while. | ||
| time.Sleep(time.Minute) |
There was a problem hiding this comment.
Constantify and raise? a minute is quite a short time isn't it? or maybe that's fine it's just opinion, but constantify at least.
|
@st-review merge |
|
@calmh: Build status is |
|
👌 Merged as 0518a92. Thanks, @AudriusButkevicius! |
st-review
pushed a commit
that referenced
this pull request
Nov 17, 2017
st-review
added
the
pr-merged
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Well Tested (TM)