Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Add option to get test coverage #5539

Merged
merged 1 commit into from Feb 14, 2019

Conversation

imsodin
Copy link
Member

@imsodin imsodin commented Feb 14, 2019

To get the whole codecov thing actually running someone with permissions to modify the build process on the team city CI. Just a step running tests with the new -coverage option and then upload the report to codecov (see https://github.com/codecov/example-go#travis-ci). Probably we should wait for the end of Jakobs holidays :)

@AudriusButkevicius AudriusButkevicius merged commit e2204d0 into syncthing:master Feb 14, 2019
@AudriusButkevicius
Copy link
Member

So I've added the coverage job. If you log in to codecov with your github creds you should be able to see the repo.
For some reason codecov thinks the builds are not finished hence does not publish coverage onto the PRs.

@imsodin
Copy link
Member Author

imsodin commented Feb 15, 2019

To me it looks like it's confused about the commit. Afaik there is some magic with new branches and merging happening on teamcity. Probably the coverage thing has to happen on a "non-magic" branch or commit/branch info must be specified explicitly to the codecov script (probably the latter). On phone right now so can't check.

@AudriusButkevicius
Copy link
Member

Fixed that, had one report where it worked out the root correctly, yet it still thinks something is pending. Perhaps Teamcity or github needs to call codecov?

@imsodin imsodin deleted the coverage branch February 18, 2019 14:58
@imsodin
Copy link
Member Author

imsodin commented Feb 18, 2019

Looks like it almost works now (it didn't pick up the .codecov.yml but I hope that happens on next master commit). The bots post are still missing as Syncthing doesn't have to codecov app activated and I don't seem to be able to do that, probably the following applies (even though it shouldn't in my opinion):

Tip: If an app requires organization-level access, then only an organization owner can purchase, install, or cancel the app, and manage app billing for the organization. If the app doesn't require organization-level access, then a repository administrator can install and uninstall the app.

Edit: I actually just now noticed what you mentioned about it still thinks CI is pending, no idea yet what's that about.

@AudriusButkevicius
Copy link
Member

I don't see why the app needs access to the org, the damn bot just makes a comment.

@calmh calmh added this to the v1.1.1 milestone Feb 25, 2019
@st-review st-review added the frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion label Feb 15, 2020
@syncthing syncthing locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
frozen-due-to-age Issues closed and untouched for a long time, together with being locked for discussion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants