cmd/stbench: rm -r cmd/stbench #6131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is apparently an old benchmarking tool. I'd forgotten about it. Since 67b8ef1 the build script tries to build all binaries explicitly by default, and this fails on Windows as this tool doesn't build on Windows. Kill it with fire.
AudriusButkevicius
approved these changes
Nov 7, 2019
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Nov 11, 2019
* master: docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143) lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147) golang-ci: Upgrade, skipping the white space complainer all: Cleanups enabled by Go 1.12 lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in lib/api: Make theme paths relative (syncthing#6142) gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115) lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140) lib/model: Remove some testing deadlocks (syncthing#6138) lib/model: Add test for previous commit lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137) lib/model: Add folders on start in model (syncthing#6135) cmd/stbench: rm -r cmd/stbench (syncthing#6131) lib/api: Slightly unflake TestCSRFRequired by allowing longer timeout Fix bufferpool puts (ref syncthing#4976) (syncthing#6125) all: Remove dead code, fix lost msgLen checks (syncthing#6129) lib/upnp: Fix outdated comment (syncthing#6110)
calmh
added a commit
to calmh/syncthing
that referenced
this pull request
Nov 11, 2019
* dbastr3: (37 commits) docker: Add stdiscosrv and strelaysrv Dockerfiles (syncthing#6143) lib/protocol: Buffer allocation when compressing (fixes syncthing#6146) (syncthing#6147) golang-ci: Upgrade, skipping the white space complainer all: Cleanups enabled by Go 1.12 lib/tlsutil: Remove Go 1.12 TLS 1.3 beta opt-in lib/api: Make theme paths relative (syncthing#6142) gui, lib/api: Adds support for prefers-color-scheme (fixes syncthing#6115) lib/api: Reset mtime after theme change (fixes syncthing#5810) (syncthing#6140) lib/model: Remove some testing deadlocks (syncthing#6138) lib/model: Add test for previous commit lib/model: Add initial deviceStatRefs on model creation (fixes syncthing#6136) (syncthing#6137) lib/model: Add folders on start in model (syncthing#6135) wip wip wip wip cmd/stbench: rm -r cmd/stbench (syncthing#6131) lib/api: Slightly unflake TestCSRFRequired by allowing longer timeout Fix bufferpool puts (ref syncthing#4976) (syncthing#6125) wip ...
st-review
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is apparently an old benchmarking tool. I'd forgotten about it.
Since 67b8ef1 the build script tries to
build all binaries explicitly by default, and this fails on Windows as
this tool doesn't build on Windows.
Kill it with fire.