all: Fix versioning path handling #7407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calmh
approved these changes
Feb 26, 2021
|
While the bug is old, exposing the versioning path in the folder edit dialog is new to v1.14.0 - that's why it was detected now. Thus I'd release a v1.14.0-rc.3 with this PR plus #7384 (it's a small change and omitting would cause conflicts). Agreed? @AudriusButkevicius @calmh |
|
Sure
|
imsodin
added a commit
that referenced
this pull request
Feb 26, 2021
10 tasks
calmh
added
the
frozen-due-to-age
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in GUI uses a wrong key for the versioning path: It should be
fsPath, but used isversionsPath. I changed the fs related options (path and type) to be members ofVersioningConfigurationdirectly instead of the "free-form" string map entries. That doesn't prevent any such mixups in JS land, but at least makes it unambiguous in Go (and anything that will be based on the protos :) ).