Allow BindDN to exclude any username formatting #8900
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix the error string being injected when the template variable for username is omitted in the LDAP Bind DN string (fixes #8899).
Testing
Regression tests have been added to check the new behavior for the original use case and the new one.
Documentation
No documentation change should be required, although the language for LDAP configuration could be changed to note that
%s
is optional. This would be in-line with the more useful use LDAP auth, which is locking a single syncthing instance to a single user account which manages it's password via LDAP.