Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

API generator update endpoint #5719

Closed
zregvart opened this issue Jun 13, 2019 · 2 comments · Fixed by #5724
Closed

API generator update endpoint #5719

zregvart opened this issue Jun 13, 2019 · 2 comments · Fixed by #5724
Labels
cat/feature PR label for a new feature closed/verified Used by QE to indicate that verified the issue group/server REST backend for managing integrations
Milestone
Sprint 47 (3/4)

Comments

@zregvart
Copy link
Member

This is a...


[x] Feature request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Bug report  
[ ] Documentation issue or request

Description

From the discussion on syndesisio/syndesis-react#456. We need a PUT /api/v1/apis/generator endpoint that receives the Integration JSON and the OpenAPI document, updates the Integration JSON according to the OpenAPI document and stores/replaces the OpenAPI document stored on the backend.
@pure-bot pure-bot bot added the notif/triage The issue needs triage. Applied automatically to all new issues. label Jun 13, 2019
@zregvart zregvart added group/server REST backend for managing integrations and removed notif/triage The issue needs triage. Applied automatically to all new issues. labels Jun 13, 2019
@zregvart zregvart added this to the Sprint 47 (3/4) milestone Jun 13, 2019
@zregvart zregvart mentioned this issue Jun 13, 2019
Merged
@paoloantinori paoloantinori added the cat/feature PR label for a new feature label Jun 13, 2019
zregvart added a commit to zregvart/syndesis that referenced this issue Jun 13, 2019
@zregvart
feat(api): add PUT /api/v1/apis/generator
37396d5 
When creating an integration from the OpenAPI document prior to saving
the integration there is a need to modify the OpenAPI document and have
the changes reflect in the integration.

This adds a `PUT /api/v1/apis/generator` that returns HTTP status `202`
and the updated integration when the provided OpenAPI document produces
changes to the integration; and HTTP status `304` with no content when
there are no changes to the integration.

There's a side effect of storing the updated OpenAPI document and
referencing it from the integration resources, if there was an update.

Fixes syndesisio#5719
@zregvart zregvart mentioned this issue Jun 13, 2019
Merged
zregvart added a commit to zregvart/syndesis that referenced this issue Jun 13, 2019
@zregvart
feat(api): add PUT /api/v1/apis/generator
6554a0a 
When creating an integration from the OpenAPI document prior to saving
the integration there is a need to modify the OpenAPI document and have
the changes reflect in the integration.

This adds a `PUT /api/v1/apis/generator` that returns HTTP status `202`
and the updated integration when the provided OpenAPI document produces
changes to the integration; and HTTP status `304` with no content when
there are no changes to the integration.

There's a side effect of storing the updated OpenAPI document and
referencing it from the integration resources, if there was an update.

Fixes syndesisio#5719
@pure-bot pure-bot bot locked as resolved and limited conversation to collaborators Jun 13, 2019
@pure-bot pure-bot bot reopened this Jun 13, 2019
@pure-bot pure-bot bot unlocked this conversation Jun 13, 2019
@mastepan
Copy link

mastepan commented Aug 7, 2019

@zregvart can you please provide steps to verify this issue? Or add ignore/QE label if verification not needed. Thanks.

@tplevko
Copy link
Contributor

tplevko commented Aug 9, 2019

The PUT endpoint is present and doing exactly what it's supposed to do. Closing as verified.

@tplevko tplevko closed this as completed Aug 9, 2019
@tplevko tplevko added the closed/verified Used by QE to indicate that verified the issue label Aug 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
cat/feature PR label for a new feature closed/verified Used by QE to indicate that verified the issue group/server REST backend for managing integrations
Projects
None yet
Milestone
Sprint 47 (3/4)
Development

Successfully merging a pull request may close this issue.

feat(api): add PUT /api/v1/apis/generator zregvart/syndesis
4 participants
@zregvart @paoloantinori @tplevko @mastepan