Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENTESB-11495] Mapping variables also on options, not only from the body #6619

Merged
merged 2 commits into from Sep 18, 2019
Merged

[ENTESB-11495] Mapping variables also on options, not only from the body #6619

merged 2 commits into from Sep 18, 2019

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Sep 17, 2019

Following #6593 now the mapping works fine in all the fields.

@syndesisio-bot
Copy link

@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-11495

@Delawen
Copy link
Contributor Author

Delawen commented Sep 17, 2019

Added a QuickStart with all the functionality: syndesisio/syndesis-quickstarts#37

@zregvart
Copy link
Member

We have a test failing on CI:

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.763 s <<< FAILURE! - in io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest

[ERROR] adaptTest(io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest)  Time elapsed: 0.763 s  <<< FAILURE!

org.junit.ComparisonFailure: expected:<...",\"properties\":{\"[:#KEY]\":{\"type\":\"strin...> but was:<...",\"properties\":{\"[clave]\":{\"type\":\"strin...>

	at io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest.adaptTest(AWSDDBMetadataAdapterTest.java:78)

zregvart
zregvart reviewed Sep 18, 2019
View reviewed changes
.../aws-ddb/src/test/java/io/syndesis/connector/aws/ddb/metadata/AWSDDBMetadataAdapterTest.java Outdated
" }\n" +
"}";

assertEquals(expectedMetadata, actualMetadata);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we could use JSONAssert here. Example of the use can be found here:

syndesis/app/common/util/src/test/java/io/syndesis/common/util/openapi/OpenApiHelperTest.java

Lines 50 to 59 in 4b628bc

@Test
public void shouldDeserializeSerializeWithoutLoosingEnumValues() throws JSONException {
final String document = "{\"swagger\":\"2.0\",\"definitions\":{\"Test\":{\"type\":\"object\",\"properties\":{\"key\":{\"type\":\"integer\",\"enum\":[1,2,3]}}}}}}}}}";
final Swagger parsed = OpenApiHelper.parse(document);
final String serialized = OpenApiHelper.serialize(parsed);
JSONAssert.assertEquals(document,
serialized, JSONCompareMode.STRICT);
}

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Delawen
Copy link
Contributor Author

Delawen commented Sep 18, 2019

We have a test failing on CI:

[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.763 s <<< FAILURE! - in io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest

[ERROR] adaptTest(io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest)  Time elapsed: 0.763 s  <<< FAILURE!

org.junit.ComparisonFailure: expected:<...",\"properties\":{\"[:#KEY]\":{\"type\":\"strin...> but was:<...",\"properties\":{\"[clave]\":{\"type\":\"strin...>

	at io.syndesis.connector.aws.ddb.metadata.AWSDDBMetadataAdapterTest.adaptTest(AWSDDBMetadataAdapterTest.java:78)

Working on the tests. Classic "on my local it worked" case :) due to non-staged changes.

@pure-bot
Copy link
Contributor

pure-bot bot commented Sep 18, 2019

Pull request approved by @oscerd - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Sep 18, 2019
@Delawen Delawen merged commit 56f5a6b into syndesisio:master Sep 18, 2019
@syndesisio-bot
Copy link

@Delawen The bot could not transition the ticket automatically, please update this Jira ticket manually: https://issues.jboss.org/browse/ENTESB-11495

@Delawen Delawen mentioned this pull request Sep 18, 2019
Merged
@Delawen Delawen deleted the aws-dynamodb-experimental branch October 11, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zregvart zregvart zregvart left review comments

@oscerd oscerd oscerd approved these changes

Assignees
No one assigned
Labels
pr/approved Applied by pure-bot when a review is approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Delawen @syndesisio-bot @zregvart @oscerd