Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port from #6619 #6637

Merged
merged 2 commits into from Sep 19, 2019
Merged

Conversation

Delawen
Copy link
Contributor

@Delawen Delawen commented Sep 18, 2019

Port from #6619

@Delawen Delawen changed the title Aws dynamodb experimental Port from #6619 Sep 18, 2019
@pure-bot
Copy link
Contributor

pure-bot bot commented Sep 18, 2019

Pull request approved by @oscerd - applying pr/approved label

@pure-bot pure-bot bot added the pr/approved Applied by pure-bot when a review is approved label Sep 18, 2019
@zregvart
Copy link
Member

@Delawen you can just add backport 1.8.x label to the pull request on master (#6619) and let the bot do the rest...

@pure-bot pure-bot bot merged commit d9a971d into syndesisio:1.8.x Sep 19, 2019
@Delawen
Copy link
Contributor Author

Delawen commented Sep 19, 2019

Magic! 💃

@backporting
Copy link

backporting bot commented Sep 19, 2019

The backport to 1.8.x failed:

Commits ["af5d82be2d7013757d95cfc5710f61f33b7ec844","352c5d1b87febe8a604c2208b49b71a2fe6d1d8d"] could not be cherry-picked on top of 1.8.x

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/backport 1.8.x
# Navigate to the new directory.
cd .worktrees/backport
# Cherry-pick all the commits of this pull request and resolve the likely conflicts.
git cherry-pick af5d82be2d7013757d95cfc5710f61f33b7ec844 352c5d1b87febe8a604c2208b49b71a2fe6d1d8d
# Create a new branch with these backported commits.
git checkout -b backport-6637-to-1.8.x
# Push it to GitHub.
git push --set-upstream origin backport-6637-to-1.8.x
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/backport

Then, create a pull request where the base branch is 1.8.x and the compare/head branch is backport-6637-to-1.8.x.

@Delawen
Copy link
Contributor Author

Delawen commented Sep 19, 2019

Nothing to compare, bot, both branches are the same.

@heiko-braun
Copy link
Collaborator

@Delawen The backport label needs to go onto the original PR that addresses master.

@Delawen Delawen deleted the aws-dynamodb-experimental branch October 11, 2019 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.8.x pr/approved Applied by pure-bot when a review is approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants