Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump basepom-oss from 30 to 32 in /app #8269

Merged
merged 8 commits into from
Jul 7, 2020

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 17, 2020

Bumps basepom-oss from 30 to 32.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot will merge this PR once CI passes on it, as requested by @Delawen.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@dependabot-preview dependabot-preview bot added the dependencies Pull requests that update a dependency file label Apr 17, 2020
@Delawen
Copy link
Contributor

Delawen commented May 7, 2020

[INFO] --- maven-enforcer-plugin:3.0.0-M3:enforce (basepom.default) @ common-parent ---
[WARNING] Rule 1: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message:
Detected JDK Version: 1.8.0-252 is not in the allowed range 9.
[WARNING] Rule 2: org.apache.maven.plugins.enforcer.RequireJavaVersion failed with message:
basepom only supports JDK version 9 and above

@Delawen
Copy link
Contributor

Delawen commented May 26, 2020

@dependabot rebase

@dependabot-preview dependabot-preview bot force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch from f163ba0 to 76ebf3f Compare May 26, 2020 09:58
@zregvart zregvart force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch 3 times, most recently from 2c1b0e5 to 968c9d6 Compare May 28, 2020 22:52
@Delawen
Copy link
Contributor

Delawen commented May 29, 2020

Jenkins failing... is that an issue?

@zregvart
Copy link
Member

retest this please

@zregvart
Copy link
Member

Jenkins failing... is that an issue?

perhaps, the "retest this please" should have re-triggered them

@zregvart
Copy link
Member

ErrorProne 2.4.0 is out, so this should use that version, i.e. remove the 968c9d6 commit and set that version.

@zregvart zregvart force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch from 968c9d6 to c947587 Compare May 30, 2020 13:10
@zregvart
Copy link
Member

This should be okay now. Some investigation needs to be done on the E2E test failures.

@Delawen
Copy link
Contributor

Delawen commented Jun 23, 2020

I can investigate about the e2e tests on #8422

@dependabot-preview
Copy link
Contributor Author

One of your CI runs failed on this pull request, so Dependabot won't merge it.

Dependabot will still automatically merge this pull request if you amend it and your tests pass.

@Delawen
Copy link
Contributor

Delawen commented Jun 23, 2020

Failing because something I was already fixing on #8422

I'm taking this issue and finishing it.

@Delawen
Copy link
Contributor

Delawen commented Jun 29, 2020

The e2e errors don't look related to this changes. They are related to http status changes on citrus (from 204 to 200) and similar stuff.

Checking on master...

@Delawen
Copy link
Contributor

Delawen commented Jun 30, 2020

The e2e errors are unrelated to this PR. They are already on the nightly build. Going to merge this then and work on the e2e on another issue #8776 8776

@Delawen
Copy link
Contributor

Delawen commented Jul 2, 2020

This is ready to be merged (once CircleCI finishes).

Anything we have to do before making JDK 11 the mandatory minimum Java version to compile Syndesis?

@Delawen Delawen linked an issue Jul 2, 2020 that may be closed by this pull request
@Delawen Delawen force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch 2 times, most recently from 9d5dea4 to ed17620 Compare July 3, 2020 12:44
@Delawen Delawen force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch 2 times, most recently from 96543fc to 3fa8b7a Compare July 6, 2020 06:51
dependabot-preview bot and others added 8 commits July 6, 2020 14:48
Bumps basepom-oss from 30 to 32.

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This reconfigures ErrorProne and CircleCI to run with Java 11.
Which is known to be non-null in io.syndesis.server.endpoint.v1.handler.connection.ConnectorIconHandler.create(MultipartFormDataInput) [io.syndesis.server.endpoint.v1.handler.connection.ConnectorIconHandler]
Redundant null check at ConnectorIconHandler.java:[line 124]
RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
@Delawen Delawen force-pushed the dependabot/maven/app/org.basepom-basepom-oss-32 branch from 3fa8b7a to b9512c2 Compare July 6, 2020 12:49
@Delawen
Copy link
Contributor

Delawen commented Jul 7, 2020

Syndesis CircleCI pass so... pushing!

@Delawen Delawen merged commit 3b839f0 into master Jul 7, 2020
@dependabot-preview dependabot-preview bot deleted the dependabot/maven/app/org.basepom-basepom-oss-32 branch July 7, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump Java version on building
2 participants