-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump basepom-oss from 30 to 32 in /app #8269
chore(deps): bump basepom-oss from 30 to 32 in /app #8269
Conversation
|
@dependabot rebase |
f163ba0
to
76ebf3f
Compare
2c1b0e5
to
968c9d6
Compare
Jenkins failing... is that an issue? |
retest this please |
perhaps, the "retest this please" should have re-triggered them |
ErrorProne 2.4.0 is out, so this should use that version, i.e. remove the 968c9d6 commit and set that version. |
968c9d6
to
c947587
Compare
This should be okay now. Some investigation needs to be done on the E2E test failures. |
I can investigate about the e2e tests on #8422 |
One of your CI runs failed on this pull request, so Dependabot won't merge it. Dependabot will still automatically merge this pull request if you amend it and your tests pass. |
Failing because something I was already fixing on #8422 I'm taking this issue and finishing it. |
The e2e errors don't look related to this changes. They are related to http status changes on citrus (from 204 to 200) and similar stuff. Checking on master... |
The e2e errors are unrelated to this PR. They are already on the nightly build. Going to merge this then and work on the e2e on another issue #8776 8776 |
...nt/src/main/java/io/syndesis/server/endpoint/v1/handler/connection/ConnectorIconHandler.java
Show resolved
Hide resolved
This is ready to be merged (once CircleCI finishes). Anything we have to do before making JDK 11 the mandatory minimum Java version to compile Syndesis? |
9d5dea4
to
ed17620
Compare
96543fc
to
3fa8b7a
Compare
Bumps basepom-oss from 30 to 32. Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
This reconfigures ErrorProne and CircleCI to run with Java 11.
Which is known to be non-null in io.syndesis.server.endpoint.v1.handler.connection.ConnectorIconHandler.create(MultipartFormDataInput) [io.syndesis.server.endpoint.v1.handler.connection.ConnectorIconHandler] Redundant null check at ConnectorIconHandler.java:[line 124] RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE
3fa8b7a
to
b9512c2
Compare
Syndesis CircleCI pass so... pushing! |
Bumps basepom-oss from 30 to 32.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot will merge this PR once CI passes on it, as requested by @Delawen.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)@dependabot use these labels
will set the current labels as the default for future PRs for this repo and language@dependabot use these reviewers
will set the current reviewers as the default for future PRs for this repo and language@dependabot use these assignees
will set the current assignees as the default for future PRs for this repo and language@dependabot use this milestone
will set the current milestone as the default for future PRs for this repo and language@dependabot badge me
will comment on this PR with code to add a "Dependabot enabled" badge to your readmeAdditionally, you can set the following in your Dependabot dashboard: