This repository has been archived by the owner on Jul 24, 2024. It is now read-only.
BACKPORT ENTESB-14596 (includes addition of ConsoleLink fix from upstream) #9052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* consolev1 api is part of openshift but not available on minikube or minishift. Therefore, need to caveat the use of consolev1.consolelink to ensure it does not hurt those other platforms. * run.go * Moves addition of scheme to where other schemes are installed * syndesis_controller.go * removeConsoleLink should only be performed if the platform supports the api in the first place * grant_olm_cluster_role.yml.tmpl * olm_cluster_role.yml.tmpl * Adds the extra cluster role and binding that allows permissions on the consolelink.console.openshift.io api permissions * Caveats with ApiServer.ConsoleLink, ie. api being present on the cluster * capabilities * Checks for consolelinks.console.openshift.io api and sets flag if present * configuration * SetConsoleLink is only performed if ConsoleLink is true # Conflicts: # install/operator/pkg/controller/syndesis/syndesis_controller.go # install/operator/pkg/generator/assets_vfsdata.go # install/operator/pkg/syndesis/configuration/configuration.go
* Simplification to use golang substitution to determine kind of binding, ie. if --cluster specified in grant command then role is marked as ClusterRole * RoleBindings can reference ClusterRoles or Roles so which is created can be dependent on whether the user specified --cluster * Separates out cluster roles and bindings into their own files * install_operator.go: no need to create extra cluster roles * Where bindings reference a service-account, the namespace is required in the subject. To avoid other namespaces overwriting, adds the namespace to the name of the binding * Namespaces removed where identified as unnecessary * ClusterRoleBindings reduced to RoleBindings where applicable * Adds all required ClusterRoles to csv so the permissions will be made available to the operator in the OperatorHub
lgarciaaco
approved these changes
Sep 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.