Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image drag'n'drop not working on Windows #3279

Closed
morevnaproject opened this issue Nov 21, 2023 · 3 comments · Fixed by #3280
Closed

Image drag'n'drop not working on Windows #3279

morevnaproject opened this issue Nov 21, 2023 · 3 comments · Fixed by #3280

Comments

@morevnaproject
Copy link
Member

Hi!
We are testing o Windows 11 latest build made on Appveyor.
It doesn't import image files through drag-n-drop.
Here's an error:
image_2023-11-21_13-08-44

At the same time, importing same image through "File" -> "Import" is working fine.

@rodolforg
Copy link
Contributor

Sorry. I'll fix it later today.

We have to test a lot of those path now :(

I'll list the needed tests later too

@ice0
Copy link
Collaborator

ice0 commented Nov 23, 2023

Hi, guys!

Sorry. I'll fix it later today.
We have to test a lot of those path now :(

No need to apologize here, we try to make the master branch as stable as possible, but we all understand that sometimes it can break.
Anyway guys, thank you for your contribution.

rodolforg added a commit to rodolforg/synfig that referenced this issue Nov 25, 2023
It doesn't strip slash character '/' before drive letter

fix synfig#3279
@rodolforg
Copy link
Contributor

rodolforg commented Nov 25, 2023

We have to test a lot of those path now :(

I'll list the needed tests later too

Tests related to files that we must do (specially on Windows with Cyrillic/Arabic as system 'locale'):

Sketch

  • Save a sketch with a pure ASCII file path
  • Save a sketch with a basename with non latin characters
  • Save a sketch on a directory with non latin characters
  • Load a sketch with a pure ASCII file path
  • Load a sketch from a basename with non latin characters
  • Load a sketch from a directory with non latin characters

Palette

  • Save a palette with a pure ASCII file path
  • Save a palette with a basename with non latin characters
  • Save a palette on a directory with non latin characters
  • Load a palette with a pure ASCII file path
  • Load a palette from a basename with non latin characters
  • Load a palette from a directory with non latin characters

Settings folder

Synfig settings path ([user-folder]/.config/synfig folder or that from SYNFIG_USER_SETTINGS environment variable):

  • Save workspaces with Synfig settings path with a pure ASCII file path
  • Load workspaces with Synfig settings path that contains non latin characters
    .
  • Save general settings with Synfig settings path with a pure ASCII file path
  • Load general settings with Synfig settings path that contains non latin characters

Import via File > Import

  • Import file with a pure ASCII file path to a NON-saved Synfig document
  • Import file with a basename with non latin characters to a NON-saved Synfig document
  • Import file from a directory with non latin characters to a NON-saved Synfig document
  • Import file from a different drive (on MS Windows only) to a NON-saved Synfig document
    .
  • Import file with a pure ASCII file path to a saved Synfig document
  • Import file with a basename with non latin characters to a saved Synfig document
  • Import file from a directory with non latin characters to a saved Synfig document
  • Import file from a different drive (on MS Windows only) to a saved Synfig document (Absolute paths don't work anymore #3212)

Import sequence via File > Import sequence

Import via drag and drop on CanvasView (#3279)

Open via File > Open

Open via drag and drop on Tool panel

Open via Recent file menu

Open via system (double click on .sif(z) document or prompt)

Sound Layer

Sound panel

Text Layer

Brushes path

Save

Export

Plugins

  • run plugin on an unsaved file
  • run plugin on a saved file with pure latin characters on file path
  • run plugin on a saved file with non latin characters on file path
  • run plugin whose installation folder has non latin character on file path

Render

Monitored files

ice0 pushed a commit that referenced this issue Nov 27, 2023
…ath on Win32) (#3280)

It doesn't strip slash character '/' before drive letter

fix #3279
@ice0 ice0 mentioned this issue Nov 27, 2023
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants