Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Edit image in external tool" does not works correctly when called from workarea #810

Closed
morevnaproject opened this issue Apr 10, 2019 · 1 comment · Fixed by #811
Closed

"Edit image in external tool" does not works correctly when called from workarea #810

morevnaproject opened this issue Apr 10, 2019 · 1 comment · Fixed by #811
Labels
Assigned Someone is working on this issue

Comments

@morevnaproject
Copy link
Member

morevnaproject commented Apr 10, 2019 •
edited

@ankit-kumar-dwivedi When I right-click image on workarea I see "Open file" menu entry, which is expected to behave the same as "Edit image in external tool" command. But when I click it, Synfig opens associated image viewer, not the editor app specified in preferences.

screenshot_001
@ankit-kumar-dwivedi
Copy link
Member

I see.. Will fix that (^_^).

@morevnaproject morevnaproject added the Assigned Someone is working on this issue label Apr 11, 2019
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Apr 12, 2019
@ankit-kumar-dwivedi
Fixes: synfig#810
d34f9b6 
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Apr 12, 2019
@ankit-kumar-dwivedi
Fixes: synfig#810
a560fb3 
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Apr 12, 2019
@ankit-kumar-dwivedi
Fixes: synfig#810
17dd57d 
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Apr 13, 2019
@ankit-kumar-dwivedi
Fixes: synfig#810
399e557 
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
@ankit-kumar-dwivedi ankit-kumar-dwivedi mentioned this issue Apr 13, 2019
Merged
morevnaproject pushed a commit that referenced this issue Apr 13, 2019
@ankit-kumar-dwivedi @morevnaproject
Fixes: #810
ecdee91 
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Assigned Someone is working on this issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix "Edit image in external tool" command for workarea ankit-kumar-dwivedi/synfig
2 participants
@morevnaproject @ankit-kumar-dwivedi