Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "Edit image in external tool" command for workarea #811

Merged
merged 1 commit into from
Apr 13, 2019

Conversation

ankit-kumar-dwivedi
Copy link
Member

@ankit-kumar-dwivedi ankit-kumar-dwivedi commented Apr 12, 2019

Fixes #810. "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.

@morevnaproject please review :)

Copy link
Member

@morevnaproject morevnaproject left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed now. Please check my comment.

synfig-studio/src/gui/instance.cpp Show resolved Hide resolved
 "Edit image in external tool" now works correctly when called from workarea. Replaced vector with set for fast find operation. created a function for confirming if the uri belongs to image layer or not.
@ankit-kumar-dwivedi
Copy link
Member Author

@morevnaproject Done Changes!

@morevnaproject
Copy link
Member

Testing now! ^__^

@morevnaproject morevnaproject changed the title Fixes: #810 Fix "Edit image in external tool" command for workarea Apr 13, 2019
@morevnaproject
Copy link
Member

Works perfectly now. Thank you! ^__^

@morevnaproject morevnaproject merged commit ecdee91 into synfig:master Apr 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Edit image in external tool" does not works correctly when called from workarea
2 participants