Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vectorization] Fix placement of vectorization result #912

Closed
morevnaproject opened this issue Aug 9, 2019 · 6 comments
Closed

[Vectorization] Fix placement of vectorization result #912

morevnaproject opened this issue Aug 9, 2019 · 6 comments
Assignees
Labels
Assigned Someone is working on this issue GSoC Gsoc Idea/Proposal

Comments

@morevnaproject
Copy link
Member

morevnaproject commented Aug 9, 2019

At the moment vectorization result is placed at the very top of layer's stack.

Here's a sample file -
test-5.zip
(notice the Translate layer on top of image layer).

screenshot_002

After vectorization it looks like this:
(notice the result is on top of layer stack and so it is shifted)

screenshot_003

How it should be:
(resulting group right on top of image layer)
screenshot_004

@ankit-kumar-dwivedi
Copy link
Member

@morevnaproject this is fixed in ankit-kumar-dwivedi@cd0f9b9
image
The panel shows correct z depth but not order.
However, the result is always created outside of the switch can you please have a look when you are free. [^_^]

@morevnaproject
Copy link
Member Author

The panel shows correct z depth but not order.

I suggest to take a look at code of `layermove" action - https://github.com/ankit-kumar-dwivedi/synfig/blob/master/synfig-studio/src/synfigapp/actions/layermove.cpp#L149 ^__^

ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 11, 2019
@ankit-kumar-dwivedi
Copy link
Member

ankit-kumar-dwivedi commented Aug 11, 2019

EDITED
@morevnaproject this is not yet fixed I'm working on it.
To-do: When inside the switch we select an image and call Vectorizer results are created outside of switch

@morevnaproject
Copy link
Member Author

@ankit-kumar-dwivedi For some reason this is not working correctly for me.

When I have the following setup:

screenshot_001

..the result is:

screenshot_002

(layer is displayed incorrectly in Layers Panel).

ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 15, 2019
@ankit-kumar-dwivedi
Copy link
Member

@morevnaproject fixed in ankit-kumar-dwivedi@20a3ae6

image

To-do: When inside the switch we select an image and call Vectorizer results are created outside of the switch

This is also fixed

@ankit-kumar-dwivedi ankit-kumar-dwivedi added Assigned Someone is working on this issue GSoC Gsoc Idea/Proposal labels Aug 15, 2019
@morevnaproject
Copy link
Member Author

Works perfectly now! ^__^

ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 21, 2019
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 21, 2019
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 31, 2019
ankit-kumar-dwivedi added a commit to ankit-kumar-dwivedi/synfig that referenced this issue Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Assigned Someone is working on this issue GSoC Gsoc Idea/Proposal
Projects
None yet
Development

No branches or pull requests

2 participants