Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Canvas Zoom Keyboard Shortcut UX #1769

Merged
merged 1 commit into from Oct 21, 2020
Merged

Conversation

AnshitaVishwa
Copy link
Contributor

@AnshitaVishwa AnshitaVishwa commented Oct 10, 2020

Fixes #1768

Initially the keyboard shortcuts for:

canvas-zoom-in:  ctrl + "="
canvas-zoom-out:  ctrl + "-"
canvas-zoom-fit:  ctrl + shift + "z"

The Improved Keyboard shortcuts for :

canvas-zoom-in:  "="
canvas-zoom-out:  "-"
canvas-zoom-fit:  "0"

@Keyikedalube
Copy link
Contributor

Keyikedalube commented Oct 11, 2020

This PR also closes my oldest issue I opened last year 👉 #1005 😁

UPDATE: Don't close my old issue yet. Another solution is already determined because the expected redo shortcut Ctrl + Shift + Z is not responding on SynfigStudio. Built and tested from this PR.

@ice0
Copy link
Collaborator

ice0 commented Oct 11, 2020

@AnshitaVishwa looks good, but please use tabs for formatting (the whole project uses tabs).

P.S. As this PR changes UX, it should be reviewed by @morevnaproject.

@AnshitaVishwa
Copy link
Contributor Author

PR updated! Replaced Spaces with Tabs.

@Keyikedalube
Copy link
Contributor

Maintainers, it's possible to have two keyboard shortcuts at the same time. For now, we have this PR implementing Inkscape style shortcuts

  1. canvas-zoom-in   : =
  2. canvas-zoom-out : -
  3. canvas-zoom-fit   : 0

The above new canvas zoom shortcuts is already paving way for UX consistency for issue #1122

However, if you want to keep the legacy style

  1. canvas-zoom-in   : Ctrl + =
  2. canvas-zoom-out : Ctrl + -
  3. canvas-zoom-fit   : Ctrl + 0 <--- New

It's possible with this PR #1776 I made; hidden menubar

So it's a win-win for both parties; improved vs legacy

@ice0
Copy link
Collaborator

ice0 commented Oct 20, 2020

However, if you want to keep the legacy style
...
It's possible with this PR #1776 I made; hidden menubar

Awesome! Which one needs to be merged first?

@morevnaproject
Copy link
Member

So it's a win-win for both parties; improved vs legacy

I agree with that. This solution looks good to me!

@Keyikedalube
Copy link
Contributor

Awesome! Which one needs to be merged first?

Either one :)

I'd merge this new contributor PR first just to avoid letting him rebase in case our changes conflict ;P

@ice0 ice0 merged commit d40c745 into synfig:master Oct 21, 2020
@ice0
Copy link
Collaborator

ice0 commented Oct 21, 2020

Merged. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
v1.4.2
Release Notes
Development

Successfully merging this pull request may close these issues.

Improve canvas zoom keyboard shortcut UX
4 participants