New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Canvas Zoom Keyboard Shortcut UX #1769
Conversation
This PR also closes my oldest issue I opened last year 👉 #1005 😁 UPDATE: Don't close my old issue yet. Another solution is already determined because the expected redo shortcut |
@AnshitaVishwa looks good, but please use tabs for formatting (the whole project uses tabs). P.S. As this PR changes UX, it should be reviewed by @morevnaproject. |
3dcdb79
to
aa316fb
Compare
PR updated! Replaced Spaces with Tabs. |
aa316fb
to
0daafca
Compare
Maintainers, it's possible to have two keyboard shortcuts at the same time. For now, we have this PR implementing Inkscape style shortcuts
The above new canvas zoom shortcuts is already paving way for UX consistency for issue #1122 However, if you want to keep the legacy style
It's possible with this PR #1776 I made; hidden menubar So it's a win-win for both parties; improved vs legacy |
Awesome! Which one needs to be merged first? |
I agree with that. This solution looks good to me! |
Either one :) I'd merge this new contributor PR first just to avoid letting him rebase in case our changes conflict ;P |
Merged. Thank you! |
Fixes #1768
Initially the keyboard shortcuts for:
The Improved Keyboard shortcuts for :