Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: smach class is now on namespace studio and more #2718

Merged
merged 2 commits into from
Jul 7, 2022
Merged

refactor!: smach class is now on namespace studio and more #2718

merged 2 commits into from
Jul 7, 2022

Conversation

rodolforg
Copy link
Contributor

Also:

  • remove smach file
  • move smach test file from ETL to synfig-studio

BREAKING CHANGE: studio API changed:

  • changed namespace of etl::smach to studio::smach

@rodolforg
Copy link
Contributor Author

(rebased)

@ice0
Copy link
Collaborator

ice0 commented Jul 7, 2022

Please rebase.

@rodolforg
refactor!: update headers for smach: it's now part of synfig studio
5edeb0a 
remove now unused header "smach"

BREAKING CHANGE: studio API changed:
- changed namespace of etl::smach to studio::smach
@rodolforg
test: move smach test from ETL to synfig-studio
acd38a5
@rodolforg
Copy link
Contributor Author

Rebased

@ice0 ice0 merged commit 18bc75f into synfig:master Jul 7, 2022
@ice0
Copy link
Collaborator

ice0 commented Jul 7, 2022

Merged. Thank you!

@rodolforg rodolforg deleted the refactor-smach branch July 8, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ice0 ice0 ice0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rodolforg @ice0