Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replacing redundant genv() #3327

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

neesaaa
Copy link
Contributor

@neesaaa neesaaa commented Feb 1, 2024

completing on pr #2826
fixes #2836

@neesaaa
Copy link
Contributor Author

neesaaa commented Feb 1, 2024

i dont know how but my build skipped some syntax errors and build 100% correctly at first , i handled it in the 2nd commit

@ice0 ice0 changed the title feat :replacing redundant genv() feat: replacing redundant genv() Feb 2, 2024
@ice0
Copy link
Collaborator

ice0 commented Feb 2, 2024

Hi!

There are two issues in this PR:
1)

std::string localdir = Glib::getenv("LOCALAPPDATA");

This environment variable (and some others) is required for correct work. They are not for debugging purposes, so no need to change them.

std::string localdir = Glib::DEBUG_GETENV("LOCALAPPDATA");

This will not work if you undefine LOGGING_ENABLED.

@neesaaa
Copy link
Contributor Author

neesaaa commented Feb 2, 2024

hi @ice0
okay so every env variable required by the program i have to leave it as it was getenv()

@neesaaa
Copy link
Contributor Author

neesaaa commented Feb 2, 2024

if u want changes to be in a new pr to see changes better no problem .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant getenv() calls
2 participants