-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant getenv() calls #2836
Comments
Hello, @morevnaproject . |
Sure, you can take it. |
@ice0 While setting up the NetBeans IDE, in the last step (Setting up make configuration, https://synfig-docs-dev.readthedocs.io/en/latest/ide/NetBeans.html), the document says:- |
What OS you are using? |
@ice0 I am using Windows |
In that case you need to use CMake-Windows-MSYS2 toolchain. https://synfig-docs-dev.readthedocs.io/en/latest/building/Preparing%20Environment.html After environment is prepared you need to run: After build is complete Currently autotools build (which is used for netbeans tutorial) is broken, so I will do CMake+NetBeans instruction tomorrow. |
After running the |
Please attach the full build log |
Here's the complete build log |
Are you sure you are running |
Hey @ice0, As I am a Newbie, I am a bit confused could you please help me with this. |
@harshvardhan-khachane |
i can give it a shot |
completing on pr synfig#2826 fixes synfig#2836
The #2826 PR improved performance by replacing
getenv()
calls.Still, there are more
getenv()
calls remaining. It would be nice to replace them, especially in render engine parts.The text was updated successfully, but these errors were encountered: