Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pressing Del during configuration prompt errors out #531

Closed
synfinatic opened this issue Aug 16, 2023 · 1 comment · Fixed by #532
Closed

Pressing Del during configuration prompt errors out #531

synfinatic opened this issue Aug 16, 2023 · 1 comment · Fixed by #532
Labels
bug Something isn't working
Milestone
v1.13.0

Comments

@synfinatic
Copy link
Owner

Output of aws-sso version:

1.12.0

Describe the bug:

✗ Hours between AWS SSO cache refresh. 0 to disable. (CacheRefresh): | 20000
>> Value must be a valid integer
FATAL   ^D

To Reproduce:

  1. aws-sso config --config config.yaml
  2. press delete key

Expected behavior:
not crash. delete character ahead of cursor

Desktop (please complete the following information):

  • OS: macOS
  • Version: Ventura 13.4.1
  • iTerm2
@synfinatic synfinatic added the bug Something isn't working label Aug 16, 2023
@synfinatic
Copy link
Owner Author

synfinatic commented Aug 16, 2023 •
edited

This is a bug in prompuit: manifoldco/promptui#179 that said, we shouldn't crash as that is our fault.

@synfinatic synfinatic added this to the v1.13.0 milestone Aug 16, 2023
synfinatic added a commit that referenced this issue Aug 16, 2023
@synfinatic
improve guided setup wizard
741dfe3 
- No longer crash if user hits ^D
- Leading and trailing spaces are now skipped
- Number of questions is dramatically reduced without `--advanced` flag

Fixes: #530
Fixes: #531
@synfinatic synfinatic mentioned this issue Aug 16, 2023
Merged
synfinatic added a commit that referenced this issue Aug 16, 2023
@synfinatic
improve guided setup wizard
15bbe1d 
- No longer crash if user hits ^D
- No longer error out on simple input errors
- Leading and trailing spaces are now skipped
- Number of questions is dramatically reduced without `--advanced` flag

Fixes: #530
Fixes: #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v1.13.0
Development

Successfully merging a pull request may close this issue.

improve guided setup wizard synfinatic/aws-sso-cli
1 participant
@synfinatic