Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve guided setup wizard #532

Merged
merged 1 commit into from
Aug 16, 2023
Merged

improve guided setup wizard #532

merged 1 commit into from
Aug 16, 2023

Conversation

synfinatic
Copy link
Owner

  • No longer crash if user hits ^D
  • Leading and trailing spaces are now skipped
  • Number of questions is dramatically reduced without --advanced flag

Fixes: #530
Fixes: #531

- No longer crash if user hits ^D
- No longer error out on simple input errors
- Leading and trailing spaces are now skipped
- Number of questions is dramatically reduced without `--advanced` flag

Fixes: #530
Fixes: #531
@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #532 (15bbe1d) into main (76ef940) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #532   +/-   ##
=======================================
  Coverage   80.60%   80.60%           
=======================================
  Files          24       24           
  Lines        2882     2882           
=======================================
  Hits         2323     2323           
  Misses        492      492           
  Partials       67       67           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ef940...15bbe1d. Read the comment docs.

@synfinatic synfinatic merged commit 7bd80dc into main Aug 16, 2023
7 checks passed
@synfinatic synfinatic deleted the simple-wizard branch August 16, 2023 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pressing Del during configuration prompt errors out Reduce options in wizard
1 participant