Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with time command #1010

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Fix crash with time command #1010

merged 1 commit into from
Jul 30, 2024

Conversation

synfinatic
Copy link
Owner

  • use RFC3339
  • Use a 10 year cert for testing

Fixes: #1008

- use RFC3339
- Use a 10 year cert for testing

Fixes: #1008
@synfinatic synfinatic added this to the 2.0.0 milestone Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.61%. Comparing base (647bc5f) to head (1ec6206).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1010   +/-   ##
=======================================
  Coverage   84.61%   84.61%           
=======================================
  Files          34       34           
  Lines        3040     3040           
=======================================
  Hits         2572     2572           
  Misses        375      375           
  Partials       93       93           
Flag Coverage Δ
unittests 84.61% <92.86%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
internal/sso/settings.go 77.36% <ø> (ø)
internal/utils/utils.go 96.12% <92.86%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 647bc5f...1ec6206. Read the comment docs.

@synfinatic synfinatic merged commit 11478d8 into main Jul 30, 2024
7 checks passed
@synfinatic synfinatic deleted the fix-time-cmd branch July 30, 2024 01:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws-sso time fails
1 participant