Issue #120: Byteorder mark removal in UncSource removes first left angle bracket '<' of xml document #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Todo: Check XmlDeclaration for encoding and read file accordingly
|
Hope this fix gets integrated asap, as it well known for more than 5 years now: https://groups.google.com/forum/#!topic/nappupdate/Irr2cIch5bQ |
|
Thank you @sonntam ! looks good, merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue of reading XML files due to BOM removal not working as described in issue #120. I added several test cases for reading differently encoded files:
Currently "foreign" (non-standard 7-bit) characters such as äöü are not supported directly if the file is encoded in an ANSI codepage format such as ISO-8859-1. I added a test case for that as well which currently fails.
In order to support ANSI encoded files some changes have to be made to the framework, i.e. the
IUpdateSource::GetUpdatesFeed()method has got to return aStreaminstead of astringfor example. This would allow the Xml Reader for checking theXmlDescriptionand itsencodingattribute. I might propose a fix for that as well some time in the future while I'm at it.