-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(wallet): Upgrade RN to 0.72.3 #1167
Conversation
Upgrades react-native to version 0.72.3. Upgrades other dependencies as needed. Applies patch to react-native-camera-kit.
Upgraded react-native-image-picker & react-native-screens.
Thanks! Able to reproduce. Looking into it. |
The error looks like it has to do with async generator code which I believe hyperswarm doesn't support. Think we had a polyfill for that once maybe that got removed or is now needed again? Maybe @limpbrains knows more. |
this is why I'm for pinning all deps in package.json. Of course it doesn't solve all the issues |
Any idea why e2e tests are failing? It looks like some async tasks are taking way longer in this build in the detox environment. I can make the tests pass locally by increasing the timeouts but on CI it's still not enough it seems. |
Same. I'm at a loss as to why this is failing. |
Detox currently doesn't support this version of react-native so probably we will have to wait for that. I don't think it's worth breaking e2e tests unless there is something major in this upgrade that we need? |
Sounds good. Lets wait. One of the added benefits of the upgrade is the potential for slightly improved error messages for troubleshooting. |
Upgrades react-native-camera-kit and removes patch-package. Upgrades react-native-reanimated, react-native-reanimated-carousel & react-native-screens.
Upgrades detox to v20.13.5.
Before merging I think we need to test it ourselfs, especially android |
Agreed. I'll run through some tests on Android in the morning. |
Android build is working as expected. No hiccups thus far. Seems we've lost the e2e-ios test again? Not sure what happened there. |
I think we can ignore it for now, I will try to fix it in another PR |
Description
This PR ensures we're on top of RN upgrades and changes so it doesn't pile up too much down the road. This PR should also improve readability of error messages within the app when crashes occur and help with troubleshooting.
Type of change
Tests