fix(settings): update channel details #2022
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pwltr
force-pushed
the
fix/channel-details
branch
from
82abf35
to
9b72158
Compare
limpbrains
requested changes
Jun 28, 2024
| /> | ||
| <Section | ||
| name={t('is_ready')} | ||
| testID={channel.is_channel_ready ? 'IsReadyYes' : 'IsReadyNo'} |
There was a problem hiding this comment.
IsReadyYes is checked in e2e tests
There was a problem hiding this comment.
I think it's ok to remove the test since it's only checking if the row exists. For debugging is_channel_ready hasn't really been useful so far
There was a problem hiding this comment.
If we are removing is_channel_ready from tests, than we need to add is_usable check.
There was a problem hiding this comment.
The test was only checking if the row exists, now it will exist always (without developer mode on) so I don't see the point of testing this. @limpbrains thoughts?
There was a problem hiding this comment.
Not just the row. Test was checking if LDK api return channel.is_channel_ready
pwltr
force-pushed
the
fix/channel-details
branch
from
9b72158
to
9141484
Compare
limpbrains
approved these changes
Jul 9, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
Tests
Screenshot / Video