Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
removed internal list of unsubscribed tags for async sockets
- this list intend was an attempt to stabilize HTTP/1.0 process, but it was in fact not a good idea at all :( - it triggered random GPF and memory leaks on highly-concurrent HTTP/1.0 connections, because TAsyncConnection pointers were reused by the MM whereas the pending results tags were still not flushed, so those new connections were in fact ignored... and eventually leaked... - to be fair, it was not a very realistic use case, but "wrk -c 16384" was able to reproduce it, if you set the server keep alive parameter to 1 second, or with Apache Bench in HTTP/1.0 mode - resulting code seems now pretty stable from HTTP/1.1 or HTTP/1.0 requests - as a side benefit, it also enhances performance, because we don't have to make an O(n) over this list any more
- Loading branch information
Arnaud Bouchez
committed
Jul 25, 2022
1 parent
5b3fd06
commit 00c3a15
Showing
3 changed files
with
10 additions
and
21 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
'2.0.3762' | ||
'2.0.3763' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters