Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static-lib unit bugs #231

Closed
wants to merge 2 commits into from
Closed

Fix static-lib unit bugs #231

wants to merge 2 commits into from

Conversation

Coldzer0
Copy link
Sponsor

@Coldzer0 Coldzer0 commented Dec 5, 2023 •
edited

After some testing related to https://synopse.info/forum/viewtopic.php?id=6767

I decided to use NOLIBCSTATIC and some code needed to be wrapped with NOLIBCSTATIC.

@Coldzer0 Coldzer0 changed the title Fix compile errors if NOLIBCSTATIC is defined Fix compiling errors if NOLIBCSTATIC is defined Dec 5, 2023
@Coldzer0
Fix fwrite redirect to _write needs a file descriptor
e95ed4a 
write needs a file descriptor of file into which data is written

So we need _fileno to convert FILE* to fd
@Coldzer0 Coldzer0 changed the title Fix compiling errors if NOLIBCSTATIC is defined Fix static unit bugs Dec 7, 2023
@Coldzer0
Copy link
Sponsor Author

Coldzer0 commented Dec 7, 2023

@synopse

I found another bug in the static unit e95ed4a
when we do write to _write we need to convert the FILE* to file descriptor

@Coldzer0
Copy link
Sponsor Author

@synopse

I found another bug in the static unit e95ed4a when we do write to _write we need to convert the FILE* to file descriptor

Any updates on this?

@Coldzer0
Copy link
Sponsor Author

Coldzer0 commented Jan 3, 2024

@synopse

Any update on this ?

@Coldzer0 Coldzer0 changed the title Fix static unit bugs Fix static-lib unit bugs Jan 15, 2024
@Coldzer0 Coldzer0 closed this Jan 26, 2024
@Coldzer0 Coldzer0 mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Coldzer0