Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why there is no support for LZMA2 in 7Zip unit ? #216

Closed
arctic-sun opened this issue Aug 26, 2023 · 4 comments
Closed

Why there is no support for LZMA2 in 7Zip unit ? #216

arctic-sun opened this issue Aug 26, 2023 · 4 comments

Comments

@arctic-sun
Copy link

-??
@synopse
Copy link
Owner

synopse commented Aug 26, 2023

Could you please elaborate a little more?
Or at least discuss this in our https://synopse.info/forum first?

@arctic-sun
Copy link
Author

you have added 7Zip dll wrapper, but it lacks support for the lzma2 compression algorithm\Method.

from: src/lib/mormot.lib.win7zip.pas

T7zCompressionMethod = ( m7Copy, m7Lzma, m7BZip2, m7Ppmd, m7Deflate, m7Deflate64);

as you can see all methods except lzma2 are present.

synopse pushed a commit that referenced this issue Aug 27, 2023
added LZMA2 compression method for 7Zip wrapper
5607672 
- as reported by #216
@synopse
Copy link
Owner

synopse commented Aug 27, 2023

Now I understand.

Please try with the commit above.

@synopse
Copy link
Owner

synopse commented Aug 29, 2023

Closing due to no feedback.
My guess is that it is fine now.

Please reopen and discuss if needed.
:)

@synopse synopse closed this as completed Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@synopse @arctic-sun