Do not use Omit type

[wooorm]

  types/index.d.ts:25:7
  ✖  25:7  Don't use Omit as a type. Prefer the Except type in the type-fest package instead as it's stricter.  @typescript-eslint/ban-types

dtslint 3 complains about these lines, what should we do?

hast-util-to-html/types/index.d.ts

Lines 24 to 26 in 0fef5aa

	entities: Partial<
	Omit<StringifyEntitiesOptions, 'escapeOnly' | 'attribute' | 'subset'>
	>

/cc @Rokt33r as you wrote the types

[Rokt33r]

In my opinion, the rule can be ignored. Omit doesn't check the omitted props exist in StringifyEntitiesOptions. So if we replace it with Except from type-fest, it would be a little bit helpful for us to detect trivial typos when we rename the omitted props in StringifyEntitiesOptions. And I don't think we would like to rename them that often. So i think we can just disable banning usage of Omit rather than introducing more dev deps.

@ChristianMurphy How do you think?

[ChristianMurphy]

I'd agree, I think adding another devDependency would like cause more frustration than the benefit Except brings. We can probably safely disable this rule.

[Rokt33r]

Awesome! I'll make a pull request to fix this issue.

[Rokt33r]

@wooorm How can I reproduce the error message? Apparently we aren't using typescript-eslint rules for this repository.

[wooorm]

I think updating dtslint to 3 gave me that error.
Xo does have typescript-eslint internally I believe

[wooorm]

Ah, I turned them off while updating: 1b34d25

[Rokt33r]

I see. I'll discard the comment and try to fix it again.

[Rokt33r]

@wooorm Hmm I think we can just close this issue now. I've checked the code again and I like the fix currently applied. We use Omit only once in this package so I don't think it is worth to configure the rule in package.json.

[wooorm]

OK! Thanks for looking into it & working on it!