Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types by moving some dev-dependencies to dependencies #2

Merged
merged 1 commit into from
Sep 3, 2021
Merged

Fix types by moving some dev-dependencies to dependencies #2

merged 1 commit into from
Sep 3, 2021

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and couldn’t find anything (or linked relevant results below)
  • If applicable, I’ve added docs and tests

Description of changes

mdast-util-mdxjs-esm depends on the types of both mdast-util-from-markdown and mdast-util-to-markdown.

`mdast-util-mdxjs-esm` depends on their types.
@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Sep 2, 2021
Copy link
Member

@ChristianMurphy ChristianMurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting 🤔
👍 for ensuring all the types are in place.
@wooorm thoughts on whether those types make sense coming from mdast-util=* packages or if they should live in @types/mdast or somewhere else?

@remcohaszing
Copy link
Member Author

FYI this is one of the type issues I ran into when upgrading xdm.

@wooorm
Copy link
Member

wooorm commented Sep 3, 2021

@ChristianMurphy I think these types:

* @typedef {import('mdast-util-from-markdown').Extension} FromMarkdownExtension
* @typedef {import('mdast-util-from-markdown').Handle} FromMarkdownHandle
* @typedef {import('mdast-util-to-markdown').Options} ToMarkdownExtension
* @typedef {import('mdast-util-to-markdown').Handle} ToMarkdownHandle

make more sense in their respective utilities, rather than adding them to @types/mdast, which I feel is more about node interfaces

@wooorm wooorm changed the title Move mdast-util-{from,to}-markdown to dependencies Fix types by moving some dev-dependencies to dependencies Sep 3, 2021
@wooorm wooorm merged commit 48a03e6 into syntax-tree:main Sep 3, 2021
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 3, 2021
@github-actions

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 3, 2021
@wooorm wooorm added ☂️ area/types This affects typings 🐛 type/bug This is a problem 👶 semver/patch This is a backwards-compatible fix labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
☂️ area/types This affects typings 💪 phase/solved Post is done 👶 semver/patch This is a backwards-compatible fix 🐛 type/bug This is a problem
Development

Successfully merging this pull request may close these issues.

None yet

3 participants