-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TypeScript type imports #3
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TypeScript 4.7 includes the new `node16` module resolution value. This requires imports to have an extension, even if the import doesn’t reference an existing `.js` file. This still works with other module resolution values.
ChristianMurphy
approved these changes
Jul 11, 2022
And to confirm, this doesn't break backwards compatibility with |
Nope, just reran |
This comment has been minimized.
This comment has been minimized.
Released in 1.2.1! |
alecmev
added a commit
to alecmev/unist-util-visit
that referenced
this pull request
Aug 21, 2022
alecmev
added a commit
to alecmev/unist-util-visit-parents
that referenced
this pull request
Aug 21, 2022
This was referenced Aug 21, 2022
wooorm
pushed a commit
to syntax-tree/unist-util-visit-parents
that referenced
this pull request
Aug 21, 2022
Closes GH-12. Related-to: syntax-tree/mdast-util-mdxjs-esm#3. Related-to: syntax-tree/unist-util-visit#35. Reviewed-by: JounQin <admin@1stg.me> Reviewed-by: Titus Wormer <tituswormer@gmail.com>
wooorm
pushed a commit
to syntax-tree/unist-util-visit
that referenced
this pull request
Aug 21, 2022
Closes GH-35. Related-to: syntax-tree/mdast-util-mdxjs-esm#3. Related-to: syntax-tree/unist-util-visit-parents#12. Reviewed-by: JounQin <admin@1stg.me> Reviewed-by: Titus Wormer <tituswormer@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
TypeScript 4.7 includes the new
node16
module resolution value. This requires imports to have an extension, even if the import doesn’t reference an existing.js
file.