Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 751 - UI Components.md #1637

Merged
merged 2 commits into from Apr 2, 2024
Merged

Create 751 - UI Components.md #1637

merged 2 commits into from Apr 2, 2024

Conversation

randyrektor
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Apr 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
syntax-website ✅ Ready (Inspect) Visit Preview Apr 2, 2024 5:53pm

@randyrektor
Copy link
Contributor Author

Wondering if these keep failing because YouTube automatically makes a video 'Private' when it's scheduled. I wonder if I left it 'Unlisted' if there would be no playback problem? @stolinski

@w3cj
Copy link
Contributor

w3cj commented Apr 2, 2024

It failed to fetch one of the costco links. Wonder if this was just a temporary flub. Re-running to see.

@randyrektor
Copy link
Contributor Author

Oh interesting! Thanks @w3cj

@w3cj
Copy link
Contributor

w3cj commented Apr 2, 2024

This URL just hangs for an HTTP/1.1 HEAD request: https://www.costco.ca/ontel-battery-daddy-180-battery-organizer-and-storage-case-with-tester.product.4000032542.html

You can replicate with CURL: curl -v -I --http1.1 https://www.costco.ca/ontel-battery-daddy-180-battery-organizer-and-storage-case-with-tester.product.4000032542.html

Really weird behavior for their server.

We probably just need to add a timeout to the URL checking and fail any URL that takes longer than X seconds to resolve.

@stolinski stolinski merged commit c5d5b29 into main Apr 2, 2024
2 of 4 checks passed
@stolinski stolinski deleted the 751-Show-Notes branch April 2, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants